From 13d778dc61c833173abcd56281a14e04b3d7b40d Mon Sep 17 00:00:00 2001 From: Fadhli Azhari Date: Tue, 28 Apr 2026 16:05:26 +0800 Subject: [PATCH] build(frontend-builder): bump default PROTOC_GEN_ES_VERSION to 2.12.0 The 2.4.0 default crashed at runtime with "protoc-gen-es: Cannot read properties of undefined (reading 'length')" when buf v1.55 invoked it. 2.12.x is current and has no such issue. KollectAI-ETL's CI no longer relies on the image's globally-installed plugin (the proto-gen workflow now does `pnpm install` in proto/ and runs `pnpm exec buf generate` to use the lockfile-pinned version), so this is mainly housekeeping for ad-hoc use inside the container. Co-Authored-By: Claude Opus 4.7 (1M context) --- ci/frontend-builder/Dockerfile | 8 +++++--- ci/frontend-builder/README.md | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/ci/frontend-builder/Dockerfile b/ci/frontend-builder/Dockerfile index 8faf8bd..7210c24 100644 --- a/ci/frontend-builder/Dockerfile +++ b/ci/frontend-builder/Dockerfile @@ -18,9 +18,11 @@ FROM node:${NODE_MAJOR}-bookworm-slim ARG PNPM_VERSION=10.15.0 ARG BUF_VERSION=1.55.0 -# Pin protoc-gen-es to a known-good major. Bump in lockstep with the -# frontend's @bufbuild/protobuf runtime version in package.json. -ARG PROTOC_GEN_ES_VERSION=2.4.0 +# Pin protoc-gen-es to a known-good version. The KollectAI-ETL CI +# workflow doesn't actually use this global install (it does +# `pnpm install` from proto/ to pick up the lockfile-pinned version) +# but we still bake it for ad-hoc use inside the container. +ARG PROTOC_GEN_ES_VERSION=2.12.0 ARG ORAS_VERSION=1.2.2 # ───────────────────────────────────────────────────────────────────── diff --git a/ci/frontend-builder/README.md b/ci/frontend-builder/README.md index 0501a94..6b91904 100644 --- a/ci/frontend-builder/README.md +++ b/ci/frontend-builder/README.md @@ -26,7 +26,7 @@ docker push 192.168.1.72/kollect-tools/ci/frontend-builder:latest | `NODE_MAJOR` | `24` | Node.js major version (matches Node base image) | | `PNPM_VERSION` | `10.15.0` | pnpm version (corepack-activated) | | `BUF_VERSION` | `1.55.0` | buf CLI version | -| `PROTOC_GEN_ES_VERSION` | `2.4.0` | `@bufbuild/protoc-gen-es` version (bump in lockstep with frontend's `@bufbuild/protobuf` runtime) | +| `PROTOC_GEN_ES_VERSION` | `2.12.0` | `@bufbuild/protoc-gen-es` version (ad-hoc use only — KollectAI-ETL CI uses the version pinned in `proto/pnpm-lock.yaml`) | | `ORAS_VERSION` | `1.2.2` | ORAS CLI version | ## Usage in CI